Resolve deprecation warnings in iw search widget
authorErik Bernhardson <ebernhardson@wikimedia.org>
Mon, 20 Aug 2018 21:58:25 +0000 (14:58 -0700)
committerErik Bernhardson <ebernhardson@wikimedia.org>
Mon, 20 Aug 2018 21:58:26 +0000 (14:58 -0700)
The old iteration api has been deprecated, but looks like this
call wasn't caught in the patch that introduced it.

Change-Id: I435bacdb185e09127606217982ca70a1bec60301

includes/widget/search/InterwikiSearchResultSetWidget.php

index b4e3414..79380de 100644 (file)
@@ -65,12 +65,10 @@ class InterwikiSearchResultSetWidget implements SearchResultSetWidget {
 
                $iwResults = [];
                foreach ( $resultSets as $resultSet ) {
-                       $result = $resultSet->next();
-                       while ( $result ) {
+                       foreach ( $resultSet as $result ) {
                                if ( !$result->isBrokenTitle() ) {
                                        $iwResults[$result->getTitle()->getInterwiki()][] = $result;
                                }
-                               $result = $resultSet->next();
                        }
                }