HTMLTextAreaField: Honor 'rows' setting in OOUI format
authorKunal Mehta <legoktm@gmail.com>
Wed, 8 Jul 2015 01:27:03 +0000 (18:27 -0700)
committerKunal Mehta <legoktm@gmail.com>
Wed, 8 Jul 2015 01:27:03 +0000 (18:27 -0700)
And throw an exception if 'cols' is set, since it won't work.

Requires eed0f5294b0080 in OOUI.

Bug: T104682
Change-Id: I8e09402a01cecac8a90497d31b3b1ca15ff2d949

includes/htmlform/HTMLTextAreaField.php

index e4f78b2..aeb4b7c 100644 (file)
@@ -47,6 +47,10 @@ class HTMLTextAreaField extends HTMLFormField {
        }
 
        function getInputOOUI( $value ) {
+               if ( isset( $this->mParams['cols'] ) ) {
+                       throw new Exception( "OOUIHTMLForm does not support the 'cols' parameter for textareas" );
+               }
+
                $attribs = $this->getTooltipAndAccessKey();
 
                if ( $this->mClass !== '' ) {
@@ -72,6 +76,7 @@ class HTMLTextAreaField extends HTMLFormField {
                        'name' => $this->mName,
                        'multiline' => true,
                        'value' => $value,
+                       'rows' => $this->getRows(),
                ) + $attribs );
        }
 }