Added some sanity close() calls to RedisConnectionPool
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 5 Nov 2013 22:18:07 +0000 (14:18 -0800)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 20 Nov 2013 21:49:51 +0000 (13:49 -0800)
Change-Id: Icd0e249a1524f880c99986c9bea3b891ab9b9ba6

includes/clientpool/RedisConnectionPool.php

index f4a2fa6..537deac 100644 (file)
@@ -316,6 +316,17 @@ class RedisConnectionPool {
 
                return true;
        }
+
+       /**
+        * Make sure connections are closed for sanity
+        */
+       function __destruct() {
+               foreach ( $this->connections as $server => &$serverConnections ) {
+                       foreach ( $serverConnections as $key => &$connection ) {
+                               $connection['conn']->close();
+                       }
+               }
+       }
 }
 
 /**