re r81495 — you know, I've completely forgotten why I wanted to return a status objec...
authorMark A. Hershberger <mah@users.mediawiki.org>
Fri, 4 Feb 2011 00:21:59 +0000 (00:21 +0000)
committerMark A. Hershberger <mah@users.mediawiki.org>
Fri, 4 Feb 2011 00:21:59 +0000 (00:21 +0000)
includes/installer/PostgresInstaller.php

index 311e7d2..9efd0f4 100644 (file)
@@ -138,10 +138,10 @@ class PostgresInstaller extends DatabaseInstaller {
                );
 
                if( !$rights || ( $rights != 1 && $rights != 3 ) ) {
-                       $status = Status::newFatal("can't create");
+                       return false;
                }
 
-               return $status;
+               return true;
        }
 
        public function getSettingsForm() {
@@ -164,7 +164,7 @@ class PostgresInstaller extends DatabaseInstaller {
                // Validate the create checkbox
                $create = true;
                $canCreate = $this->canCreateAccounts();
-               if ( !$canCreate->isOK() ) {
+               if ( $canCreate ) {
                        $this->setVar( '_CreateDBAccount', false );
                        $create = false;
                } else {