Make setSubmitProgressive() Deprecate

Bug: T191586
Change-Id: Ie310ea9c3ca7c9e4b8755ba500e2ccafd0b64463

diff --git a/RELEASE-NOTES-1.32 b/RELEASE-NOTES-1.32
index 2eb3679..6426045 100644 (file)
--- a/RELEASE-NOTES-1.32
+++ b/RELEASE-NOTES-1.32
@@ -62,6 +62,8 @@ changes to languages because of Phabricator reports.
   configuration in LocalSettings.php.
 
 === Other changes in 1.32 ===
+* HTMLForm::setSubmitProgressive() is deprecated. No need to call. Submit
+  button already has a progressive action form.
 * …
 
 == Compatibility ==

diff --git a/includes/htmlform/HTMLForm.php b/includes/htmlform/HTMLForm.php
index af1743e..45a4143 100644 (file)
--- a/includes/htmlform/HTMLForm.php
+++ b/includes/htmlform/HTMLForm.php
@@ -1336,10 +1336,13 @@ class HTMLForm extends ContextSource {
        /**
         * Identify that the submit button in the form has a progressive action
         * @since 1.25
+        * @deprecated since 1.32, No need to call. Submit button already
+        * has a progressive action form.
         *
         * @return HTMLForm $this for chaining calls (since 1.28)
         */
        public function setSubmitProgressive() {
+               wfDeprecated( __METHOD__, '1.32' );
                $this->mSubmitFlags = [ 'progressive', 'primary' ];
 
                return $this;