Made prepareContentForEdit() use the stash cache by default
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 9 Dec 2014 22:23:11 +0000 (14:23 -0800)
committerOri.livneh <ori@wikimedia.org>
Tue, 9 Dec 2014 22:26:36 +0000 (22:26 +0000)
Change-Id: I1123a8da4764df67f1b0f2b18f6ea74ec5be7be9

includes/api/ApiStashEdit.php
includes/page/WikiPage.php

index fd5bd7e..2bb0b5c 100644 (file)
@@ -108,8 +108,8 @@ class ApiStashEdit extends ApiBase {
                        $editInfo = false;
                        $status = 'ratelimited';
                } elseif ( $wgMemc->lock( $key, 0, 30 ) ) {
-                       $contentFormat = $content->getDefaultFormat();
-                       $editInfo = $page->prepareContentForEdit( $content, null, $user, $contentFormat );
+                       $format = $content->getDefaultFormat();
+                       $editInfo = $page->prepareContentForEdit( $content, null, $user, $format, false );
                        $status = 'error'; // default
                        $unlocker = new ScopedCallback( function() use ( $key ) {
                                global $wgMemc;
index 8b26c23..75df27c 100644 (file)
@@ -1783,7 +1783,7 @@ class WikiPage implements Page, IDBAccessObject {
                        $summary = $handler->getAutosummary( $old_content, $content, $flags );
                }
 
-               $editInfo = $this->prepareContentForEdit( $content, null, $user, $serialFormat, true );
+               $editInfo = $this->prepareContentForEdit( $content, null, $user, $serialFormat );
                $serialized = $editInfo->pst;
 
                /**
@@ -2076,7 +2076,7 @@ class WikiPage implements Page, IDBAccessObject {
         * @since 1.21
         */
        public function prepareContentForEdit(
-               Content $content, $revid = null, User $user = null, $serialFormat = null, $useCache = false
+               Content $content, $revid = null, User $user = null, $serialFormat = null, $useCache = true
        ) {
                global $wgContLang, $wgUser;