deleteEqualMessages: Exclude messages that are empty by default

The main purpose of this script is to purge local overrides to
avoid them from blocking an i18n update in the future.

However empty messages should remain empty and often have a
richer edit history (e.g. Sitenotice) and may not stay empty
for long.

Change-Id: I5b416cda25a3641862df9919c46ae59ad5d5d6e0

diff --git a/maintenance/deleteEqualMessages.php b/maintenance/deleteEqualMessages.php
index 1e36363..8175891 100644 (file)
--- a/maintenance/deleteEqualMessages.php
+++ b/maintenance/deleteEqualMessages.php
@@ -70,7 +70,13 @@ class DeleteEqualMessages extends Maintenance {
                                $default = wfMessage( $key )->inLanguage( $langCode )->useDatabase( false )->plain();
 
                                $messageInfo['relevantPages']++;
-                               if ( $actual === $default ) {
+
+                               if (
+                                       // Exclude messages that are empty by default, such as sitenotice, specialpage
+                                       // summaries and accesskeys.
+                                       $default !== '' && $default !== '-' &&
+                                               $actual === $default
+                               ) {
                                        $hasTalk = isset( $statuses['talks'][$key] );
                                        $messageInfo['results'][] = array(
                                                'title' => $key . $titleSuffix,