Can't use return value of void functions
authorReedy <reedy@wikimedia.org>
Sat, 16 Jun 2012 13:42:30 +0000 (14:42 +0100)
committerReedy <reedy@wikimedia.org>
Sat, 16 Jun 2012 13:42:30 +0000 (14:42 +0100)
Change-Id: Idce6e31f3f0eff0a0045c1cc62def3f5d79b9d48

includes/ChangesList.php
includes/db/DatabaseIbm_db2.php

index d280c9a..4ddc667 100644 (file)
@@ -1171,7 +1171,7 @@ class EnhancedChangesList extends ChangesList {
                } else { 
                        $r .= ' '.$rcObj->userlink . $rcObj->usertalklink;
                        $r .= $this->insertComment( $rcObj );
-                       $r .= $this->insertRollback( $r, $rcObj );
+                       $this->insertRollback( $r, $rcObj );
                }
 
                # Tags
index 5df6456..1fdcd5c 100644 (file)
@@ -1433,7 +1433,7 @@ class DatabaseIbm_db2 extends DatabaseBase {
                // db2_ping() doesn't exist
                // Emulate
                $this->close();
-               $this->mConn = $this->openUncataloged( $this->mDBName, $this->mUser,
+               $this->openUncataloged( $this->mDBName, $this->mUser,
                        $this->mPassword, $this->mServer, $this->mPort );
 
                return false;