Don't report image cache hits / misses

This single metric is responsible for a substantial proportion of overall
statsd traffic on the Wikimedia cluster, per the task cited below. Nobody is
closely monitoring this statistic. We can reintroduce it with sampling at a
later date if it is deemed to be useful.

Bug: T101141
Change-Id: I6457cb91d527ce42c0918ac4e80613e6b59061ac

diff --git a/includes/filerepo/file/LocalFile.php b/includes/filerepo/file/LocalFile.php
index 9677f5d..40b2226 100644 (file)
--- a/includes/filerepo/file/LocalFile.php
+++ b/includes/filerepo/file/LocalFile.php
@@ -267,12 +267,6 @@ class LocalFile extends File {
                        }
                }
 
-               if ( $this->dataLoaded ) {
-                       wfIncrStats( 'image_cache.hit' );
-               } else {
-                       wfIncrStats( 'image_cache.miss' );
-               }
-
                return $this->dataLoaded;
        }