mediawiki.special.apisandbox: Avoid bitwise tricks when checking for integers
authorBartosz Dziewoński <matma.rex@gmail.com>
Wed, 14 Dec 2016 13:33:13 +0000 (14:33 +0100)
committerBartosz Dziewoński <matma.rex@gmail.com>
Wed, 14 Dec 2016 13:33:13 +0000 (14:33 +0100)
In addition to being more obvious than `n | 0`, `Math.floor( n )` also
works correctly for numbers outside of 32-bit int range.

Change-Id: I254457500e141c0dd4e28c707fb4a00c1b04c272

resources/src/mediawiki.special/mediawiki.special.apisandbox.js

index 60155fd..43321fe 100644 (file)
                                                } else {
                                                        n = +value;
                                                        return !isNaN( n ) && isFinite( n ) &&
-                                                               // eslint-disable-next-line no-bitwise
-                                                               ( n | 0 ) === n &&
+                                                               Math.floor( n ) === n &&
                                                                n >= pi.min && n <= pi.apiSandboxMax;
                                                }
                                        } );