Reduce code duplication in requires
authorChad Horohoe <demon@users.mediawiki.org>
Wed, 10 Feb 2010 01:44:09 +0000 (01:44 +0000)
committerChad Horohoe <demon@users.mediawiki.org>
Wed, 10 Feb 2010 01:44:09 +0000 (01:44 +0000)
maintenance/doMaintenance.php

index f99072b..f13ca07 100644 (file)
@@ -57,6 +57,10 @@ if ( file_exists( "$IP/StartProfiler.php" ) ) {
        require_once( "$IP/includes/ProfilerStub.php" );
 }
 
+// Some other requires
+require_once( "$IP/includes/AutoLoader.php" );
+require_once( "$IP/includes/Defines.php" );
+
 // Load settings, using wikimedia-mode if needed
 // Fixme: replace this hack with general farm-friendly code
 if( file_exists( "$IP/wmf-config/wikimedia-mode" ) ) {
@@ -65,15 +69,11 @@ if( file_exists( "$IP/wmf-config/wikimedia-mode" ) ) {
        global $cluster;
        $wgWikiFarm = true;
        $cluster = 'pmtpa';
-       require_once( "$IP/includes/AutoLoader.php" );
        require_once( "$IP/includes/SiteConfiguration.php" );
        require( "$IP/wmf-config/wgConf.php" );
        $maintenance->loadWikimediaSettings();
-       require( $IP.'/includes/Defines.php' );
        require( $IP.'/wmf-config/CommonSettings.php' );
 } else {
-       require_once( "$IP/includes/AutoLoader.php" );
-       require_once( "$IP/includes/Defines.php" );
        require_once( $maintenance->loadSettings() );
 }
 $maintenance->finalSetup();