filebackend: avoid use of LoadBalancer::newMainLB() in LockManagerGroup
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 16 Jul 2019 03:47:07 +0000 (20:47 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Tue, 16 Jul 2019 06:31:15 +0000 (06:31 +0000)
Change-Id: Iffe9f75ddc9cdbea8a4b5e1932dd55ae325f9dbc

includes/filebackend/lockmanager/LockManagerGroup.php

index 43f6010..957af3e 100644 (file)
@@ -121,10 +121,13 @@ class LockManagerGroup {
                        $config = $this->managers[$name]['config'];
                        if ( $class === DBLockManager::class ) {
                                $lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
-                               $lb = $lbFactory->newMainLB( $config['domain'] );
-                               $dbw = $lb->getLazyConnectionRef( DB_MASTER, [], $config['domain'] );
-
-                               $config['dbServers']['localDBMaster'] = $dbw;
+                               $lb = $lbFactory->getMainLB( $config['domain'] );
+                               $config['dbServers']['localDBMaster'] = $lb->getLazyConnectionRef(
+                                       DB_MASTER,
+                                       [],
+                                       $config['domain'],
+                                       $lb::CONN_TRX_AUTOCOMMIT
+                               );
                                $config['srvCache'] = ObjectCache::getLocalServerInstance( 'hash' );
                        }
                        $config['logger'] = LoggerFactory::getInstance( 'LockManager' );