Suppress warnings around copy call
authorReedy <reedy@wikimedia.org>
Mon, 17 Dec 2012 21:18:50 +0000 (21:18 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sat, 22 Dec 2012 18:25:34 +0000 (18:25 +0000)
Attempt to shut some noise in production logs

Change-Id: I4bac4027d82e4194b6ec46658d52f49038db573c
Warning:  copy(/mnt/thumbs2/wikipedia/commons/thumb/8/8c/Map_of_USA_AK_full.png/120px-Map_of_USA_AK_full.png) [<a href='function.copy'>function.copy</a>]: failed to open stream: No such file or directory in /usr/local/apache/common-local/php-1.21wmf6/includes/filebackend/FSFileBackend.php on line 254

includes/filebackend/FSFileBackend.php

index c60abb1..9450257 100644 (file)
@@ -251,7 +251,9 @@ class FSFileBackend extends FileBackendStore {
                        ) );
                        $status->value = new FSFileOpHandle( $this, $params, 'Store', $cmd, $dest );
                } else { // immediate write
+                       wfSuppressWarnings();
                        $ok = copy( $params['src'], $dest );
+                       wfRestoreWarnings();
                        // In some cases (at least over NFS), copy() returns true when it fails
                        if ( !$ok || ( filesize( $params['src'] ) !== filesize( $dest ) ) ) {
                                if ( $ok ) { // PHP bug