Split out UserInputWidgets from mediawiki.widgets
authorFlorian <florian.schmidt.stargatewissen@gmail.com>
Mon, 5 Oct 2015 17:50:15 +0000 (19:50 +0200)
committerKunal Mehta <legoktm@gmail.com>
Wed, 7 Oct 2015 15:54:35 +0000 (08:54 -0700)
Move it to its own module mediawiki.widgets.UserInputWidget. It's
currently used in HTMLUserTextField only.

Bug: T108733
Change-Id: Id8c6dd5d9616086bdb0918442bfafe9ec708ab31

includes/htmlform/HTMLUserTextField.php
resources/Resources.php
resources/src/mediawiki/page/ready.js

index 5869002..9617c0a 100644 (file)
@@ -40,7 +40,7 @@ class HTMLUserTextField extends HTMLTextField {
        }
 
        protected function getInputWidget( $params ) {
-               $this->mParent->getOutput()->addModules( 'mediawiki.widgets' );
+               $this->mParent->getOutput()->addModules( 'mediawiki.widgets.UserInputWidget' );
 
                return new UserInputWidget( $params );
        }
index 5504fd7..f0b7cd5 100644 (file)
@@ -1967,7 +1967,6 @@ return array(
                        'resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js',
                        'resources/src/mediawiki.widgets/mw.widgets.ComplexTitleInputWidget.js',
                        'resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js',
-                       'resources/src/mediawiki.widgets/mw.widgets.UserInputWidget.js',
                ),
                'skinStyles' => array(
                        'default' => array(
@@ -2039,6 +2038,14 @@ return array(
                ),
                'targets' => array( 'desktop', 'mobile' ),
        ),
+       'mediawiki.widgets.UserInputWidget' => array(
+               'scripts' => array(
+                       'resources/src/mediawiki.widgets/mw.widgets.UserInputWidget.js',
+               ),
+               'dependencies' => array(
+                       'oojs-ui',
+               ),
+       ),
 
        /* es5-shim */
        'es5-shim' => array(
index 8ec4cf0..9505bdd 100644 (file)
@@ -62,7 +62,8 @@
                // Infuse OOUI widgets, if any are present
                $nodes = $( '[data-ooui]' );
                if ( $nodes.length ) {
-                       mw.loader.using( 'mediawiki.widgets' ).done( function () {
+                       // FIXME: We should only load the widgets that are being infused
+                       mw.loader.using( [ 'mediawiki.widgets', 'mediawiki.widgets.UserInputWidget' ] ).done( function () {
                                $nodes.each( function () {
                                        OO.ui.infuse( this );
                                } );