Fix warning on Special:ListGroupRights for group with invalid group page
authorumherirrender <umherirrender_de.wp@web.de>
Mon, 29 Dec 2014 18:24:20 +0000 (19:24 +0100)
committerumherirrender <umherirrender_de.wp@web.de>
Mon, 29 Dec 2014 18:24:20 +0000 (19:24 +0100)
Avoids
Notice: Linker::link: Requires $target to be a Title object. [Called
from SpecialListGroupRights::execute in
\includes\specials\SpecialListgrouprights.php at line 97]

Change-Id: Ie90ea33b0f57861985a296380e4ee7296dac79af

includes/specials/SpecialListgrouprights.php

index 8b9a0ee..828a93b 100644 (file)
@@ -86,13 +86,14 @@ class SpecialListGroupRights extends SpecialPage {
                        $grouppageLocalized = !$msg->isBlank() ?
                                $msg->text() :
                                MWNamespace::getCanonicalName( NS_PROJECT ) . ':' . $groupname;
+                       $grouppageLocalizedTitle = Title::newFromText( $grouppageLocalized );
 
-                       if ( $group == '*' ) {
-                               // Do not make a link for the generic * group
+                       if ( $group == '*' || !$grouppageLocalizedTitle ) {
+                               // Do not make a link for the generic * group or group with invalid group page
                                $grouppage = htmlspecialchars( $groupnameLocalized );
                        } else {
                                $grouppage = Linker::link(
-                                       Title::newFromText( $grouppageLocalized ),
+                                       $grouppageLocalizedTitle,
                                        htmlspecialchars( $groupnameLocalized )
                                );
                        }