Follow up to r46613 (Allow local redirects to foreign images):

* This doesn't work like it should. We seem to be returning metadata about the target (ie: it does in fact exist), but at some point it all goes null. Making a note in ImagePage
* Reverting RELEASE-NOTES until this is right.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index c4dc3b8..3e40a01 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -71,8 +71,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   can now be determined and set with ParserOptions.
 * Wrap message 'confirmemail_pending' into a div with CSS classes "error" and
   "mw-confirmemail-pending"
-* Local redirects to foreign images are now displayed on the ImagePage when
-  viewing on the local wiki.
 * (bug 8249) The magic words for namespaces and pagenames can now be used as
   parser functions to return the desired namespace or normalized title/title
   part for a given title.

diff --git a/includes/ImagePage.php b/includes/ImagePage.php
index 9eed236..b6964d6 100644 (file)
--- a/includes/ImagePage.php
+++ b/includes/ImagePage.php
@@ -127,6 +127,8 @@ class ImagePage extends Article {
                        array( 'id' => 'filelinks' ),
                        wfMsg( 'imagelinks' ) ) . "\n" );
                $this->imageDupes();
+               # TODO! FIXME! For some freaky reason, we can't redirect to foreign images.
+               # Yet we return metadata about the target. Definitely an issue in the FileRepo
                $this->imageRedirects();
                $this->imageLinks();