Likely that nobody is calling getPath() on a ForeignAPI repo, but best to warn them...

diff --git a/includes/filerepo/File.php b/includes/filerepo/File.php
index c8b1cde..5d51e4c 100644 (file)
--- a/includes/filerepo/File.php
+++ b/includes/filerepo/File.php
@@ -229,6 +229,8 @@ abstract class File {
        * i.e. whether the files are all found in the same directory,
        * or in hashed paths like /images/3/3c.
        *
+       * Most callers don't check the return value, but ForeignAPIFile::getPath
+       * returns false.
        */
        public function getPath() {
                if ( !isset( $this->path ) ) {