Per brion's suggestion, changed <? to <?php in Syslog, and change

functions to strings in Syslog and hooks.doc examples.

diff --git a/docs/hooks.doc b/docs/hooks.doc
index 27f4cb7..bd4740d 100644 (file)
--- a/docs/hooks.doc
+++ b/docs/hooks.doc
@@ -107,9 +107,9 @@ functions to the appropriate events:
     setupTitleReversingExtension() {
         global $wgHooks;
        
-       $wgHooks['ArticleShow'][] = reverseArticleTitle;
-       $wgHooks['ArticleDelete'][] = reverseArticleTitle;
-       $wgHooks['ArticleExport'][] = reverseForExport;
+       $wgHooks['ArticleShow'][] = 'reverseArticleTitle';
+       $wgHooks['ArticleDelete'][] = 'reverseArticleTitle';
+       $wgHooks['ArticleExport'][] = 'reverseForExport';
     }
 
 Having all this code related to the title-reversion option in one
@@ -139,9 +139,9 @@ A hook is a chunk of code run at some particular event. It consists of:
 Hooks are registered by adding them to the global $wgHooks array for a
 given event. All the following are valid ways to define hooks:
 
-      $wgHooks['EventName'][] = someFunction; # function, no data
-      $wgHooks['EventName'][] = array(someFunction, $someData);
-      $wgHooks['EventName'][] = array(someFunction); # weird, but OK
+      $wgHooks['EventName'][] = 'someFunction'; # function, no data
+      $wgHooks['EventName'][] = array('someFunction', $someData);
+      $wgHooks['EventName'][] = array('someFunction'); # weird, but OK
       
       $wgHooks['EventName'][] = $object; # object only
       $wgHooks['EventName'][] = array($object, 'someMethod');
@@ -172,8 +172,8 @@ would be different: 'onArticleSave', 'onUserLogin', etc.
 The extra data is useful if we want to use the same function or object
 for different purposes. For example:
 
-      $wgHooks['ArticleSaveComplete'][] = array(ircNotify, 'TimStarling');
-      $wgHooks['ArticleSaveComplete'][] = array(ircNotify, 'brion');
+      $wgHooks['ArticleSaveComplete'][] = array('ircNotify', 'TimStarling');
+      $wgHooks['ArticleSaveComplete'][] = array('ircNotify', 'brion');
 
 This code would result in ircNotify being run twice when an article is
 saved: once for 'TimStarling', and once for 'brion'.
@@ -190,7 +190,7 @@ the main functionality. For example, if you wanted to authenticate
 users to a custom system (LDAP, another PHP program, whatever), you
 could do:
 
-    $wgHooks['UserLogin'][] = array(ldapLogin, $ldapServer);
+    $wgHooks['UserLogin'][] = array('ldapLogin', $ldapServer);
                                
     function ldapLogin($username, $password) {
         # log user into LDAP

diff --git a/extensions/Syslog.php b/extensions/Syslog.php
index 78bc912..5287739 100644 (file)
--- a/extensions/Syslog.php
+++ b/extensions/Syslog.php
@@ -1,4 +1,4 @@
-<?
+<?php
 /* Syslog.php -- an extension to log events to the system logger
  * Copyright 2004 Evan Prodromou <evan@wikitravel.org>
  *
@@ -71,10 +71,10 @@ if (defined('MEDIAWIKI')) {
                
                openlog($wgSyslogIdentity, LOG_ODELAY | LOG_PID, $wgSyslogFacility);
                
-               $wgHooks['UserLoginComplete'][] = syslogUserLogin;
-               $wgHooks['UserLogout'][] = syslogUserLogout;
-               $wgHooks['BlockIpComplete'][] = syslogBlockIp;
-               $wgHooks['ArticleProtectComplete'][] = syslogArticleProtect;
+               $wgHooks['UserLoginComplete'][] = 'syslogUserLogin';
+               $wgHooks['UserLogout'][] = 'syslogUserLogout';
+               $wgHooks['BlockIpComplete'][] = 'syslogBlockIp';
+               $wgHooks['ArticleProtectComplete'][] = 'syslogArticleProtect';
                
                return true;
        }