Join user table to recentchanges on user id, rather than user_text
authorSam Reed <reedy@users.mediawiki.org>
Sun, 13 Mar 2011 18:23:33 +0000 (18:23 +0000)
committerSam Reed <reedy@users.mediawiki.org>
Sun, 13 Mar 2011 18:23:33 +0000 (18:23 +0000)
Add some documentation

includes/specials/SpecialActiveusers.php

index f016ab9..7d6d2c0 100644 (file)
  */
 class ActiveUsersPager extends UsersPager {
 
+       /**
+        * @var FormOptions
+        */
+       protected $opts;
+
+       /**
+        * @var Array
+        */
+       protected $groups;
+
        function __construct( $group = null ) {
                global $wgRequest, $wgActiveUserDays;
                $this->RCMaxAge = $wgActiveUserDays;
@@ -96,7 +106,7 @@ class ActiveUsersPager extends UsersPager {
                                'USE INDEX' => array( 'recentchanges' => 'rc_user_text' )
                        ),
                        'join_conds' => array(
-                               'user' => array( 'INNER JOIN', 'rc_user_text=user_name' ),
+                               'user' => array( 'INNER JOIN', 'rc_user=user_id' ),
                                'ipblocks' => array( 'LEFT JOIN', 'user_id=ipb_user AND ipb_auto=0 AND ipb_deleted=1' ),
                        ),
                        'conds' => $conds