Add new message 'brackets' and use it to kill some hardcoded []s.

Change-Id: Idae8d9201d1c291316ab520d204ae8c5cde2d890

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index c6572b1..d280c9a 100644 (file)
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -874,8 +874,10 @@ class EnhancedChangesList extends ChangesList {
                        array_push( $users, $text );
                }
 
-               $users = ' <span class="changedby">[' .
-                       implode( $this->message['semicolon-separator'], $users ) . ']</span>';
+               $users = ' <span class="changedby">'
+                       . $this->getContext()->msg( 'brackets' )->rawParams(
+                               implode( $this->message['semicolon-separator'], $users )
+                       )->plain() . '</span>';
 
                $tl = '<span class="mw-collapsible-toggle mw-enhancedchanges-arrow"></span>';
                $r .= "<td>$tl</td>";

diff --git a/includes/Linker.php b/includes/Linker.php
index 8e02fd9..722df3a 100644 (file)
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -1641,9 +1641,9 @@ class Linker {
         * @return string
         */
        public static function generateRollback( $rev ) {
-               return '<span class="mw-rollback-link">['
-                       . self::buildRollbackLink( $rev )
-                       . ']</span>';
+               return '<span class="mw-rollback-link">'
+                       . wfMessage( 'brackets' )->rawParams( self::buildRollbackLink( $rev ) )->plain()
+                       . '</span>';
        }
 
        /**

diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php
index 9ac58ae..dcddc10 100644 (file)
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -4426,6 +4426,7 @@ Please confirm that you really want to recreate this page.",
 'ellipsis'            => '...', # only translate this message to other languages if you have to change it
 'percent'             => '$1%', # only translate this message to other languages if you have to change it
 'parentheses'         => '($1)', # only translate this message to other languages if you have to change it
+'brackets'            => '[$1]', # only translate this message to other languages if you have to change it
 
 # Multipage image navigation
 'imgmultipageprev' => '← previous page',

diff --git a/maintenance/language/messageTypes.inc b/maintenance/language/messageTypes.inc
index 42354ea..3a9b18e 100644 (file)
--- a/maintenance/language/messageTypes.inc
+++ b/maintenance/language/messageTypes.inc
@@ -452,6 +452,7 @@ $wgOptionalMessages = array(
        'ellipsis',
        'percent',
        'parentheses',
+       'brackets',
        'autocomment-prefix',
        'listgrouprights-right-display',
        'listgrouprights-right-revoked',

diff --git a/maintenance/language/messages.inc b/maintenance/language/messages.inc
index f2823a0..8b6618d 100644 (file)
--- a/maintenance/language/messages.inc
+++ b/maintenance/language/messages.inc
@@ -3321,6 +3321,7 @@ $wgMessageStructure = array(
                'ellipsis',
                'percent',
                'parentheses',
+               'brackets',
        ),
        'imgmulti' => array(
                'imgmultipageprev',