Follow up r64932: Add comment on why % is escaped
authorBryan Tong Minh <btongminh@users.mediawiki.org>
Sun, 11 Apr 2010 13:54:22 +0000 (13:54 +0000)
committerBryan Tong Minh <btongminh@users.mediawiki.org>
Sun, 11 Apr 2010 13:54:22 +0000 (13:54 +0000)
includes/media/Bitmap.php

index 9b082b2..f911644 100644 (file)
@@ -157,6 +157,7 @@ class BitmapHandler extends ImageHandler {
                                // or ImageMagick may decide your ratio is wrong and slice off
                                // a pixel.
                                " -thumbnail " . wfEscapeShellArg( "{$physicalWidth}x{$physicalHeight}!" ) .
+                               // A % is an escape character in ImageMagick
                                " -set comment " . wfEscapeShellArg( str_replace( '%', '%%', $descriptionUrl ) ) .
                                " -depth 8 $sharpen " .
                                wfEscapeShellArg($dstPath) . " 2>&1";