mediawiki.action.edit.preview: Use .textSelection( 'getContents' )
authorFomafix <fomafix@googlemail.com>
Thu, 1 Jan 2015 12:59:46 +0000 (12:59 +0000)
committer[[mw:User:Fomafix]] <gerritpatchuploader@gmail.com>
Thu, 1 Jan 2015 12:59:46 +0000 (12:59 +0000)
Replace .val() by .textSelection( 'getContents' )
for '#wpTextbox1' and '#wpSummary'.
This is already supported by extension CodeEditor.

$( mw ).trigger( 'LivePreviewPrepare' ) is not needed anymore.

Bug: T78838
Change-Id: I30bd709d8b4778f45f3d5f395201e0ca6ce18891

resources/Resources.php
resources/src/mediawiki.action/mediawiki.action.edit.preview.js

index ccb842d..a52a2f3 100644 (file)
@@ -1044,6 +1044,7 @@ return array(
                'dependencies' => array(
                        'jquery.form',
                        'jquery.spinner',
+                       'jquery.textSelection',
                        'mediawiki.api',
                        'mediawiki.action.history.diff',
                        'mediawiki.util',
index 9bf1352..f6fab70 100644 (file)
@@ -13,9 +13,6 @@
 
                e.preventDefault();
 
-               // Deprecated: Use mw.hook instead
-               $( mw ).trigger( 'LivePreviewPrepare' );
-
                isDiff = ( e.target.name === 'wpDiff' );
                $wikiPreview = $( '#wikiPreview' );
                $wikiDiff = $( '#wikiDiff' );
@@ -64,8 +61,8 @@
                        action: 'parse',
                        uselang: mw.config.get( 'wgUserLanguage' ),
                        title: mw.config.get( 'wgPageName' ),
-                       text: $editform.find( '#wpTextbox1' ).val(),
-                       summary: $editform.find( '#wpSummary' ).val()
+                       text: $editform.find( '#wpTextbox1' ).textSelection( 'getContents' ),
+                       summary: $editform.find( '#wpSummary' ).textSelection( 'getContents' )
                };
 
                if ( isDiff ) {