If this was ever passed an empty string it would spit "PHP Notice: Uninitialized...

diff --git a/includes/db/DatabaseMysql.php b/includes/db/DatabaseMysql.php
index 2b32fd0..759d1ac 100644 (file)
--- a/includes/db/DatabaseMysql.php
+++ b/includes/db/DatabaseMysql.php
@@ -330,7 +330,7 @@ class DatabaseMysql extends DatabaseBase {
        }
 
        public function isQuotedIdentifier( $name ) {
-               return $name[0] == '`' && substr( $name, -1, 1 ) == '`';
+               return strlen($name) && $name[0] == '`' && substr( $name, -1, 1 ) == '`';
        }
 
        function ping() {