api: Remove 'recenteditcount' set for BC to be removed in 1.25

This was a TODO that needed cleanup in mediawiki version 1.25 but
code was still hanging around. Removing it as we're in .34

Change-Id: I0d996362612495b3c523aed5af3a0e30ee4ed79c

diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34
index 219cba4..82b72db 100644 (file)
--- a/RELEASE-NOTES-1.34
+++ b/RELEASE-NOTES-1.34
@@ -55,7 +55,8 @@ For notes on 1.33.x and older releases, see HISTORY.
 * …
 
 === Action API changes in 1.34 ===
-* …
+* The 'recenteditcount' response property from action=query list=allusers,
+  deprecated in 1.25, has been removed.
 
 === Action API internal changes in 1.34 ===
 * …
@@ -93,6 +94,8 @@ because of Phabricator reports.
   This behavior was removed, and the method now matches the parent signature
   (SpecialPage::execute) which is to return HTML string or void.
   To obtain the destination title, use RedirectSpecialPage::getRedirect.
+* The 'recenteditcount' response property from action API action=query
+  list=allusers, deprecated in 1.25, has been removed.
 
 === Deprecations in 1.34 ===
 * The MWNamespace class is deprecated. Use MediaWikiServices::getNamespaceInfo.

diff --git a/includes/api/ApiQueryAllUsers.php b/includes/api/ApiQueryAllUsers.php
index 8b3d864..161cfb4 100644 (file)
--- a/includes/api/ApiQueryAllUsers.php
+++ b/includes/api/ApiQueryAllUsers.php
@@ -285,8 +285,6 @@ class ApiQueryAllUsers extends ApiQueryBase {
                        }
                        if ( $params['activeusers'] ) {
                                $data['recentactions'] = (int)$row->recentactions;
-                               // @todo 'recenteditcount' is set for BC, remove in 1.25
-                               $data['recenteditcount'] = $data['recentactions'];
                        }
                        if ( $fld_registration ) {
                                $data['registration'] = $row->user_registration ?