Avoid a fatal error in maintenance/cleanupTitles.php

Title::makeTitleSafe() can return null; so only call
exists() if an object was returned, and otherwise behave
the same way as if the page existed: use another name.

Change-Id: I75ea5c5b25fa5fdf6646a177a5fbccc0dbff9b47

diff --git a/maintenance/cleanupTitles.php b/maintenance/cleanupTitles.php
index eee1204..0df9e7f 100644 (file)
--- a/maintenance/cleanupTitles.php
+++ b/maintenance/cleanupTitles.php
@@ -156,7 +156,7 @@ class TitleCleanup extends TableCleanup {
 
                        $clean = 'Broken/' . $prior;
                        $verified = Title::makeTitleSafe( $ns, $clean );
-                       if ( $verified->exists() ) {
+                       if ( !$verified || $verified->exists() ) {
                                $blah = "Broken/id:" . $row->page_id;
                                $this->output( "Couldn't legalize; form '$clean' exists; using '$blah'\n" );
                                $verified = Title::makeTitleSafe( $ns, $blah );