Removed deprecated unused method in RedisConnectionPool.php

There are no usages of RedisConnectionPool::handleException() in core or extensions
so it can safely be removed.

Bug: T61113
Change-Id: Icd9ceb394625e9610f5071d13fbfd2760c464870

diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29
index 5824909..e66b9ce 100644 (file)
--- a/RELEASE-NOTES-1.29
+++ b/RELEASE-NOTES-1.29
@@ -168,7 +168,7 @@ changes to languages because of Phabricator reports.
 * Linker::getInternalLinkAttributes() (deprecated since 1.25) was removed.
 * Linker::getInternalLinkAttributesObj() (deprecated since 1.25) was removed.
 * Linker::getLinkAttributesInternal() (deprecated since 1.25) was removed.
-
+* RedisConnectionPool::handleException (deprecated since 1.23) was removed.
 == Compatibility ==
 
 MediaWiki 1.29 requires PHP 5.5.9 or later. There is experimental support for

diff --git a/includes/libs/redis/RedisConnectionPool.php b/includes/libs/redis/RedisConnectionPool.php
index 49d09a9..7f43436 100644 (file)
--- a/includes/libs/redis/RedisConnectionPool.php
+++ b/includes/libs/redis/RedisConnectionPool.php
@@ -319,21 +319,6 @@ class RedisConnectionPool implements LoggerAwareInterface {
                }
        }
 
-       /**
-        * The redis extension throws an exception in response to various read, write
-        * and protocol errors. Sometimes it also closes the connection, sometimes
-        * not. The safest response for us is to explicitly destroy the connection
-        * object and let it be reopened during the next request.
-        *
-        * @param string $server
-        * @param RedisConnRef $cref
-        * @param RedisException $e
-        * @deprecated since 1.23
-        */
-       public function handleException( $server, RedisConnRef $cref, RedisException $e ) {
-               $this->handleError( $cref, $e );
-       }
-
        /**
         * The redis extension throws an exception in response to various read, write
         * and protocol errors. Sometimes it also closes the connection, sometimes