(bug 43207) Fix regression in API generator=duplicatefiles
authorBrad Jorsch <bjorsch@wikimedia.org>
Mon, 17 Dec 2012 19:11:47 +0000 (14:11 -0500)
committerBrad Jorsch <bjorsch@wikimedia.org>
Mon, 17 Dec 2012 19:11:47 +0000 (14:11 -0500)
Prior to change I745cae7a, generator=duplicatefiles would return all the
files that were duplicates of the passed files. Since then, it will
return only one of the input files if any duplicates are found, possibly
one that doesn't even have duplicates.

The problem is the use of a wrong variable.

Change-Id: I8e8493718ab1f7f5cb6ae718790738a7cf3c72c7

includes/api/ApiQueryDuplicateFiles.php

index 8f0fd3b..f088062 100644 (file)
@@ -133,7 +133,7 @@ class ApiQueryDuplicateFiles extends ApiQueryGeneratorBase {
                                        break;
                                }
                                if ( !is_null( $resultPageSet ) ) {
-                                       $titles[] = $file->getTitle();
+                                       $titles[] = $dupFile->getTitle();
                                } else {
                                        $r = array(
                                                'name' => $dupName,