Log when User::saveSettings is called in read-only mode

Change-Id: I56a1760f2e6bbda889590777b553a8dfda587590

diff --git a/includes/User.php b/includes/User.php
index 322f8af..d832cbd 100644 (file)
--- a/includes/User.php
+++ b/includes/User.php
@@ -3586,7 +3586,13 @@ class User implements IDBAccessObject {
                global $wgAuth;
 
                if ( wfReadOnly() ) {
-                       return; // @TODO: caller should deal with this instead!
+                       // @TODO: caller should deal with this instead!
+                       // This should really just be an exception.
+                       MWExceptionHandler::logException( new DBExpectedError(
+                               null,
+                               "Could not update user with ID '{$this->mId}'; DB is read-only."
+                       ) );
+                       return;
                }
 
                $this->load();