Kill broken OOUI implementations of HTMLSelectAndOtherField, HTMLSelectOrOtherField
authorBartosz Dziewoński <matma.rex@gmail.com>
Sun, 26 Jul 2015 23:22:56 +0000 (01:22 +0200)
committerBartosz Dziewoński <matma.rex@gmail.com>
Sun, 26 Jul 2015 23:42:23 +0000 (01:42 +0200)
They inherited getInputOOUI() from their respective parents, which
obviously didn't work correctly. These shouldn't be inheriting from
incompatible parents, probably… but meh.

Change-Id: Id99ee74c4efd27fab0ee32555723a02df8015458

includes/htmlform/HTMLSelectAndOtherField.php
includes/htmlform/HTMLSelectOrOtherField.php

index 23ca3bf..0e4f4f3 100644 (file)
@@ -64,6 +64,10 @@ class HTMLSelectAndOtherField extends HTMLSelectField {
                return "$select<br />\n$textbox";
        }
 
+       function getInputOOUI( $value ) {
+               return false;
+       }
+
        /**
         * @param WebRequest $request
         *
index cbf7d12..3e7acdf 100644 (file)
@@ -62,6 +62,10 @@ class HTMLSelectOrOtherField extends HTMLTextField {
                return "$select<br />\n$textbox";
        }
 
+       function getInputOOUI( $value ) {
+               return false;
+       }
+
        /**
         * @param WebRequest $request
         *