Declare visibility on class properties of SpecialUndelete
authorSiebrand Mazeland <siebrand@kitano.nl>
Sun, 23 Mar 2014 00:05:21 +0000 (01:05 +0100)
committerChad <chadh@wikimedia.org>
Wed, 26 Mar 2014 17:14:51 +0000 (17:14 +0000)
All class properties are used solely in the class itself. SpecialUndelete
is not being subclassed, so made all properties private.

Change-Id: I32792fb5d21178d850764c0efe3024d957fca2a8

includes/specials/SpecialUndelete.php

index e8a45a7..55ab32d 100644 (file)
@@ -674,11 +674,20 @@ class PageArchive {
  * @ingroup SpecialPage
  */
 class SpecialUndelete extends SpecialPage {
-       var $mAction, $mTarget, $mTimestamp, $mRestore, $mInvert, $mFilename;
-       var $mTargetTimestamp, $mAllowed, $mCanView, $mComment, $mToken;
+       private $mAction;
+       private $mTarget;
+       private $mTimestamp;
+       private $mRestore;
+       private $mInvert;
+       private $mFilename;
+       private $mTargetTimestamp;
+       private $mAllowed;
+       private $mCanView;
+       private $mComment;
+       private $mToken;
 
        /** @var Title */
-       var $mTargetObj;
+       private $mTargetObj;
 
        function __construct() {
                parent::__construct( 'Undelete', 'deletedhistory' );