Remove redundant line-height declarations from elements.css

Elements.css declares line-height of 1.5em for certain common
elements, like ol, ul and dd. These are redundant as each skin already
declares the same line-height for the content, and all elements inherit
this line-height from the body.

At the same time, these declaration override the content line-height of
1.6em set in Vector, creating inconsistencies that cannot be 'hacked'
away. Removing these line-height declarations has no impact, other
then making the typography refresh actually work as intended.

Bug: T66653
Change-Id: I5b682a9527294e96f3999773724cbf8fb9631197

diff --git a/resources/src/mediawiki.skinning/elements.css b/resources/src/mediawiki.skinning/elements.css
index eb57abb..8140d1a 100644 (file)
--- a/resources/src/mediawiki.skinning/elements.css
+++ b/resources/src/mediawiki.skinning/elements.css
@@ -141,7 +141,6 @@ h5 {
 
 p {
        margin: .4em 0 .5em 0;
-       line-height: 1.5em;
 }
 
 p img {
@@ -149,14 +148,12 @@ p img {
 }
 
 ul {
-       line-height: 1.5em;
        list-style-type: square;
        margin: .3em 0 0 1.6em;
        padding: 0;
 }
 
 ol {
-       line-height: 1.5em;
        margin: .3em 0 0 3.2em;
        padding: 0;
        list-style-image: none;
@@ -177,7 +174,6 @@ dl {
 }
 
 dd {
-       line-height: 1.5em;
        margin-left: 1.6em;
        margin-bottom: .1em;
 }
@@ -215,7 +211,6 @@ fieldset {
        border: 1px solid #2f6fab;
        margin: 1em 0 1em 0;
        padding: 0 1em 1em;
-       line-height: 1.5em;
 }
 
 fieldset.nested {