Move insertUpdateRow call before return applyPatch to make it reachable
authorReedy <reedy@wikimedia.org>
Sun, 9 Dec 2012 02:33:51 +0000 (02:33 +0000)
committerReedy <reedy@wikimedia.org>
Sun, 9 Dec 2012 02:33:51 +0000 (02:33 +0000)
This might not be quite right... We might want to cache the result of apply patch, insert the row and then return the result...

Change-Id: Ie6a1bb16d2912ad43aa8fd45b2bf10a8bf8652ae

includes/installer/DatabaseUpdater.php

index b200dcf..913eef5 100644 (file)
@@ -721,8 +721,8 @@ abstract class DatabaseUpdater {
                } elseif( $this->updateRowExists( $updateKey ) ) {
                        $this->output( "...$field in table $table already modified by patch $patch.\n" );
                } else {
-                       return $this->applyPatch( $patch, $fullpath, "Modifying $field field of table $table" );
                        $this->insertUpdateRow( $updateKey );
+                       return $this->applyPatch( $patch, $fullpath, "Modifying $field field of table $table" );
                }
                return true;
        }