Add sanity check to notifyUpdatesForRevision() for $oldRev
authorAaron Schulz <aschulz@wikimedia.org>
Sat, 9 Mar 2019 20:27:29 +0000 (12:27 -0800)
committerAaron Schulz <aschulz@wikimedia.org>
Sat, 9 Mar 2019 20:27:29 +0000 (12:27 -0800)
Change-Id: Ibd8975efb33d061ab16dc1a59899b6f78976ec5d

includes/jobqueue/jobs/CategoryMembershipChangeJob.php

index b64c87a..3aedc38 100644 (file)
@@ -195,7 +195,7 @@ class CategoryMembershipChangeJob extends Job {
                // Get the prior revision (the same for null edits)
                if ( $newRev->getParentId() ) {
                        $oldRev = Revision::newFromId( $newRev->getParentId(), Revision::READ_LATEST );
-                       if ( !$oldRev->getContent() ) {
+                       if ( !$oldRev || !$oldRev->getContent() ) {
                                return; // deleted?
                        }
                } else {