Merge "Avoid function calls in the loop condition of a for statement"

diff --combined thumb.php
index fe50e2e,2d7cca7..d53c10c
--- 1/thumb.php
--- 2/thumb.php
+++ b/thumb.php
@@@ -388,8 -388,7 +388,8 @@@ function wfGenerateThumbnail( File $fil
        $errorHtml = false;
  
        // guard thumbnail rendering with PoolCounter to avoid stampedes
 -      // expensive files use a separate PoolCounter config so it is possible to set up a global limit on them
 +      // expensive files use a separate PoolCounter config so it is possible
 +      // to set up a global limit on them
        if ( $file->isExpensiveToThumbnail() ) {
                $poolCounterType = 'FileRenderExpensive';
        } else {
@@@ -521,7 -520,8 +521,8 @@@ function wfExtractThumbRequestInfo( $th
        $repo = RepoGroup::singleton()->getLocalRepo();
  
        $hashDirReg = $subdirReg = '';
-       for ( $i = 0; $i < $repo->getHashLevels(); $i++ ) {
+       $hashLevels = $repo->getHashLevels();
+       for ( $i = 0; $i < $hashLevels; $i++ ) {
                $subdirReg .= '[0-9a-f]';
                $hashDirReg .= "$subdirReg/";
        }