Avoid assignment in return in TemplateParser.php
authorumherirrender <umherirrender_de.wp@web.de>
Wed, 17 Jun 2015 20:12:47 +0000 (22:12 +0200)
committerumherirrender <umherirrender_de.wp@web.de>
Wed, 17 Jun 2015 20:16:36 +0000 (22:16 +0200)
Hard to read and may misread as boolean return

Change-Id: If6bfdbed7e647dde51db62ae6901874a83682d9e

includes/TemplateParser.php

index 3de70fa..d53d593 100644 (file)
@@ -130,7 +130,8 @@ class TemplateParser {
                if ( !is_callable( $renderer ) ) {
                        throw new RuntimeException( "Requested template, {$templateName}, is not callable" );
                }
-               return $this->renderers[$templateName] = $renderer;
+               $this->renderers[$templateName] = $renderer;
+               return $renderer;
        }
 
        /**