* Removed mockup code from WebInstallerPage::execute(), made it abstract instead.
authorTim Starling <tstarling@users.mediawiki.org>
Wed, 30 Jun 2010 03:36:20 +0000 (03:36 +0000)
committerTim Starling <tstarling@users.mediawiki.org>
Wed, 30 Jun 2010 03:36:20 +0000 (03:36 +0000)
* Updated URL for session.save_path documentation.
* Fixed documentation typo.

includes/installer/LocalSettingsGenerator.php
includes/installer/WebInstaller.php

index aae9aad..ca3ccf3 100644 (file)
@@ -7,7 +7,7 @@ class LocalSettingsGenerator {
        private $installer;
 
        /**
-        * Construtor.
+        * Constructor.
         * @param $installer Installer subclass
         */
        public function __construct( Installer $installer ) {
@@ -263,4 +263,4 @@ if ( \$wgCommandLineMode ) {
 \$wgCacheEpoch = max( \$wgCacheEpoch, gmdate( 'YmdHis', @filemtime( __FILE__ ) ) );
 ";
        }
-}
\ No newline at end of file
+}
index 547bf66..4d16e2d 100644 (file)
@@ -238,7 +238,7 @@ class WebInstaller extends Installer {
        /**
         * Get the value of session.save_path
         *
-        * Per http://www.php.net/manual/en/ref.session.php#ini.session.save-path,
+        * Per http://www.php.net/manual/en/session.configuration.php#ini.session.save-path,
         * this might have some additional preceding parts which need to be
         * ditched
         *
@@ -803,7 +803,7 @@ class WebInstaller extends Installer {
        }
 }
 
-class WebInstallerPage {
+abstract class WebInstallerPage {
        function __construct( $parent ) {
                $this->parent = $parent;
        }
@@ -863,15 +863,7 @@ class WebInstallerPage {
                return array_search( $this->getName(), $this->parent->pageSequence );
        }
 
-       function execute() {
-               if ( $this->parent->request->wasPosted() ) {
-                       return 'continue';
-               } else {
-                       $this->startForm();
-                       $this->addHTML( 'Mockup' );
-                       $this->endForm();
-               }
-       }
+       abstract function execute();
 
        function getVar( $var ) {
                return $this->parent->getVar( $var );