Fix media type handling for CSS that's not loaded with only=styles
authorCatrope <roan.kattouw@gmail.com>
Wed, 13 Jun 2012 23:50:13 +0000 (16:50 -0700)
committerCatrope <roan.kattouw@gmail.com>
Wed, 13 Jun 2012 23:50:13 +0000 (16:50 -0700)
We were only doing server-side @media wrapping in only=styles mode but
not in regular mode. Meanwhile, the client-side loader had dropped all
support for media types under the assumption that this was all handled
server side, which caused media type handling to break for modules
loaded the normal way. We didn't notice this before because the only
core module that uses this is skins.vector, which is loaded through
only=styles.

Change-Id: I8228cc0317328440256b45b166eef1b57dbf4602

includes/resourceloader/ResourceLoader.php

index 9e88494..599f43e 100644 (file)
@@ -752,8 +752,12 @@ class ResourceLoader {
                                                                }
                                                        }
                                                }
-                                               $out .= self::makeLoaderImplementScript( $name, $scripts, $styles,
-                                                       new XmlJsCode( $messagesBlob ) );
+                                               $out .= self::makeLoaderImplementScript(
+                                                       $name,
+                                                       $scripts,
+                                                       self::makeCombinedStyles( $styles ),
+                                                       new XmlJsCode( $messagesBlob )
+                                               );
                                                break;
                                }
                        } catch ( Exception $e ) {