generateUpgradeKey() could produce NULL return, which means a fatal error when

Call to a member function isOk() in includes/installer/WebInstallerPage.php on line 1039

diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php
index 507ba2e..9206b36 100644 (file)
--- a/includes/installer/Installer.php
+++ b/includes/installer/Installer.php
@@ -1352,6 +1352,7 @@ abstract class Installer {
                if ( strval( $this->getVar( 'wgUpgradeKey' ) ) === '' ) {
                        return $this->generateSecret( 'wgUpgradeKey', 16 );
                }
+               return Status::newGood();
        }
 
        /**