(bug 22753) update.php should make things it actually changed stand out better in...

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index d443da6..c83426a 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -470,6 +470,8 @@ LocalSettings.php. The specific bugs are listed below in the general notes.
 * (bug 10871) Javascript and CSS pages in MediaWiki namespace are no longer treated
   as wikitext on preview.
 * (bug 25512) Subcategory list should not include category prefix for members.
+* (bug 22753) Output from update.php is more clear when things changed, entries
+  indicating nothing changed are now all prefixed by "..."
 
 === API changes in 1.17 ===
 * (bug 22738) Allow filtering by action type on query=logevent.

diff --git a/includes/installer/MysqlUpdater.php b/includes/installer/MysqlUpdater.php
index 50376a5..7e1f8b1 100644 (file)
--- a/includes/installer/MysqlUpdater.php
+++ b/includes/installer/MysqlUpdater.php
@@ -617,13 +617,17 @@ class MysqlUpdater extends DatabaseUpdater {
         * @see bug 3946
         */
        protected function doPageRandomUpdate() {
-               $this->output( "Setting page_random to a random value on rows where it equals 0..." );
+               
 
                $page = $this->db->tableName( 'page' );
                $this->db->query( "UPDATE $page SET page_random = RAND() WHERE page_random = 0", __METHOD__ );
                $rows = $this->db->affectedRows();
 
-               $this->output( "changed $rows rows\n" );
+               if( $rows ) {
+                       $this->output( "Set page_random to a random value on $row rows where it was set to 0\n" );
+               } else {
+                       $this->output( "...no page_random rows needed to be set\n" );
+               }
        }
 
        protected function doTemplatelinksUpdate() {