The insert() method calls insertOneRow() method on line 391. It then
passes $fname which defaults to __METHOD__ in its function header and
not using $fname instead of __METHOD__ in insertOneRow() method makes
this parameter unused which of course should be used.
Change-Id: Ic5f5ee878e4f919a96900ba88755641ac85929df
$this->mLastResult = $stmt = oci_parse( $this->conn, $sql );
if ( $stmt === false ) {
$e = oci_error( $this->conn );
$this->mLastResult = $stmt = oci_parse( $this->conn, $sql );
if ( $stmt === false ) {
$e = oci_error( $this->conn );
- $this->reportQueryError( $e['message'], $e['code'], $sql, __METHOD__ );
+ $this->reportQueryError( $e['message'], $e['code'], $sql, $fname );
$val = $this->getVerifiedUTF8( $val );
if ( oci_bind_by_name( $stmt, ":$col", $val, -1, SQLT_CHR ) === false ) {
$e = oci_error( $stmt );
$val = $this->getVerifiedUTF8( $val );
if ( oci_bind_by_name( $stmt, ":$col", $val, -1, SQLT_CHR ) === false ) {
$e = oci_error( $stmt );
- $this->reportQueryError( $e['message'], $e['code'], $sql, __METHOD__ );
+ $this->reportQueryError( $e['message'], $e['code'], $sql, $fname );
if ( oci_execute( $stmt, $this->execFlags() ) === false ) {
$e = oci_error( $stmt );
if ( !$this->ignoreDupValOnIndex || $e['code'] != '1' ) {
if ( oci_execute( $stmt, $this->execFlags() ) === false ) {
$e = oci_error( $stmt );
if ( !$this->ignoreDupValOnIndex || $e['code'] != '1' ) {
- $this->reportQueryError( $e['message'], $e['code'], $sql, __METHOD__ );
+ $this->reportQueryError( $e['message'], $e['code'], $sql, $fname );