Remove 'noclasses' from Linker::linkKnown() defaults
authorKunal Mehta <legoktm@member.fsf.org>
Thu, 19 May 2016 21:42:52 +0000 (14:42 -0700)
committerKunal Mehta <legoktm@member.fsf.org>
Fri, 20 May 2016 02:07:58 +0000 (19:07 -0700)
commitc66b6a1e437185d5ad8410f27c7df680d3433fd0
tree93a89b7f87bbb0e96702b988230e4b0020cd6eef
parentaff17edd95620bff595dfa88013b422b38b1db2a
Remove 'noclasses' from Linker::linkKnown() defaults

The intention for Linker::linkKnown() was to be used when the caller had
already preloaded the target's existence ('known') and called
Linker::getLinkColour() directly ('noclasses'). However, nearly all
usage of linkKnown() only did the first part, and not the latter.

So do what people actually ended up using the function for, and remove
'noclasses' from the default parameters. As long as the target the link
is being created for is already in LinkCache, this shouldn't cause any
extra database queries.

Change-Id: Ia5a4c2f18ec780627146617a1498bd04fcfbb3ee
includes/DummyLinker.php
includes/Linker.php
tests/parser/parserTests.txt