rdbms: Document a bunch of stuff about query verbs
authorTimo Tijhof <krinklemail@gmail.com>
Fri, 28 Sep 2018 23:42:43 +0000 (00:42 +0100)
committerKrinkle <krinklemail@gmail.com>
Fri, 28 Sep 2018 23:49:10 +0000 (23:49 +0000)
commitaeb6a921324770e475e6583aa69dab830d81144e
tree1b05f03d680248888f82434c0261b9dd4ed2b5b9
parent0560dd430f8a2595b01226ef471650f4ea144031
rdbms: Document a bunch of stuff about query verbs

The decision to treat COMMIT/BEGIN as a "read" in isWriteQuery()
for the benefit of ChronologyProtector was first introduced
in r47360 (8653947b, 2009).

* Re-order strings in isTransactableQuery() to match the regular
  expression in isWriteQuery() for quicker mental comparison

* Add missing visibility to DatabaseSqlite->isWriteQuery, matching
  the parent class implementation.

Bug: T201900
Change-Id: Ic90f6455a2e696ba9428ad5835d0f4be6a0d9a5c
includes/libs/rdbms/database/Database.php
includes/libs/rdbms/database/DatabaseSqlite.php