Cleanup static analysis errors
authorErik Bernhardson <ebernhardson@wikimedia.org>
Wed, 7 Dec 2016 00:06:39 +0000 (16:06 -0800)
committerErik Bernhardson <ebernhardson@wikimedia.org>
Wed, 7 Dec 2016 00:10:38 +0000 (16:10 -0800)
commit90538900208d227c360613cda8c7904ce2e9dacb
tree48934d3e89d068535f3b601c4f4aa7c4ac58aa0a
parent127c0072c4d29902fbf2dcfd63464042462270ed
Cleanup static analysis errors

While prepping the code base for using etsy/phan i found a few problems.
A couple are real problems, while others are just places etsy couldn't
figure out the types.

* AuthPlugin referenced UserLoginTemplate which doesn't exist. Tracing
  back usages this accepts classes that extend from BaseTemplate.
* DatabaseSqlite had an invalid @var annotation.
* LoadBalancer had some missing or under-defined annotations. Make them
  more specific where possible.
* SqlBagOStuff didn't have the appropriate use statement for
  WaitConditionLoop and probably doesn't work. Also updated annotations
  that point to non-existent DatabaseBase to use IDatabase.

Change-Id: Iff2270b418ad2f8f97cfdb6df646c435d3283536
includes/AuthPlugin.php
includes/libs/rdbms/database/DatabaseSqlite.php
includes/libs/rdbms/loadbalancer/LoadBalancer.php
includes/objectcache/SqlBagOStuff.php
maintenance/backup.inc