Blame hashar for this giant commit; he teased me for making so many smaller ones...
authorHappy-melon <happy-melon@users.mediawiki.org>
Mon, 21 Mar 2011 19:12:41 +0000 (19:12 +0000)
committerHappy-melon <happy-melon@users.mediawiki.org>
Mon, 21 Mar 2011 19:12:41 +0000 (19:12 +0000)
commit6dbcdc1be097167c25a9b9a95956a9b765204216
tree1c5cf524436d4384817c9741c98a95f22dbc2aba
parent55d6855e0e4f349870d4fd2a4b0df0c754454ca7
Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D
* Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId().
* This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions.
* Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter)
* Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S
* Remove transitionary getTargetAndType() and newFromTargetAndType() methods
* Some optimisation in parseTarget()
* Fix the broken phpunit test mentioned in r84251
12 files changed:
includes/Article.php
includes/Block.php
includes/OutputPage.php
includes/Title.php
includes/User.php
includes/api/ApiBlock.php
includes/api/ApiUnblock.php
includes/specials/SpecialBlock.php
includes/specials/SpecialBlockme.php
includes/specials/SpecialUnblock.php
includes/specials/SpecialUserlogin.php
tests/phpunit/includes/api/ApiBlockTest.php