(bug 30640; follow-up r92279) Rotating images was making skewed images
authorBrian Wolff <bawolff@users.mediawiki.org>
Fri, 9 Sep 2011 20:13:09 +0000 (20:13 +0000)
committerBrian Wolff <bawolff@users.mediawiki.org>
Fri, 9 Sep 2011 20:13:09 +0000 (20:13 +0000)
commit57228556e66e3e0925412f7b22a1b5e13640cf71
tree487dd7aba6ff746b6eb32fd8f634feae780b06ce
parentc0d4714fa5d095c7fa3ae24afc2ffe6536b05b0f
(bug 30640; follow-up r92279) Rotating images was making skewed images

This is Bryan's patch from bug 30640 with a couple minor related changes, plus some unit tests.
This also addresses an issue with preventing too-big images from being scaled from r92279.

I also noticed that image magick's rotation support is broken in 6.3.7 (the version I had installed locally. I've since upgraded) I'm not sure if we should be doing something about that...

I did test this without both image magick, and gd (although only very briefly with gd) both seemed to work well. I didn't test any other image scalars.
includes/media/Bitmap.php
tests/phpunit/includes/media/BitmapScalingTest.php
tests/phpunit/includes/media/ExifRotationTest.php