Move avoidance of setting deleted cookies into WebResponse
authorBrad Jorsch <bjorsch@wikimedia.org>
Sat, 23 Jan 2016 16:13:11 +0000 (11:13 -0500)
committerBryanDavis <bdavis@wikimedia.org>
Mon, 25 Jan 2016 03:34:11 +0000 (03:34 +0000)
commit4d6d06253b28ee1fac28301ef596d78c1ba7859b
tree6b9fd15b088634fda5ff1bf1b42d5799d28bf7a2
parent90453fe8e3aeaac93427f3aaf26dd79ba4bc08aa
Move avoidance of setting deleted cookies into WebResponse

There's no reason this should be only in CookieSessionProvider when
we're already handling deduplication in WebResponse.

Further, this fixes the bug in the existing CookieSessionProvider
implementation that a setCookie() followed by a clearCookie() wouldn't
actually clear the cookie.

This reverts commit 1ce684fcef1ee69ca0921c05081cae47f90939e5.

Bug: T124252
Change-Id: I1098d054facacd59f03ebed7c747ec9ff6bf66e7
Depends-On: I61d14bf80fa7c857dec9cffb366dc3f84dbb4faf
includes/WebResponse.php
includes/session/CookieSessionProvider.php
tests/phpunit/includes/session/CookieSessionProviderTest.php