X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2Fspecialpage%2FSpecialPageFactoryTest.php;h=f79f6e48c55aa913c13ef1f0cb24546b1b45b50e;hb=1dd2e07276e1deaf431ddb01c92111038f9e2cd6;hp=145ffb3547cc56bcf91189a94d7363befc5d9369;hpb=a5be382adfdad4678eec18413c6a118cb3284daf;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/specialpage/SpecialPageFactoryTest.php b/tests/phpunit/includes/specialpage/SpecialPageFactoryTest.php
index 145ffb3547..f79f6e48c5 100644
--- a/tests/phpunit/includes/specialpage/SpecialPageFactoryTest.php
+++ b/tests/phpunit/includes/specialpage/SpecialPageFactoryTest.php
@@ -57,17 +57,19 @@ class SpecialPageFactoryTest extends MediaWikiTestCase {
 		$specialPageTestHelper = new SpecialPageTestHelper();
 
 		return [
-			'class name' => [ 'SpecialAllPages' ],
+			'class name' => [ 'SpecialAllPages', false ],
 			'closure' => [ function () {
 				return new SpecialAllPages();
-			} ],
-			'function' => [ [ $this, 'newSpecialAllPages' ] ],
-			'callback string' => [ 'SpecialPageTestHelper::newSpecialAllPages' ],
+			}, false ],
+			'function' => [ [ $this, 'newSpecialAllPages' ], false ],
+			'callback string' => [ 'SpecialPageTestHelper::newSpecialAllPages', false ],
 			'callback with object' => [
-				[ $specialPageTestHelper, 'newSpecialAllPages' ]
+				[ $specialPageTestHelper, 'newSpecialAllPages' ],
+				false
 			],
 			'callback array' => [
-				[ 'SpecialPageTestHelper', 'newSpecialAllPages' ]
+				[ 'SpecialPageTestHelper', 'newSpecialAllPages' ],
+				false
 			]
 		];
 	}
@@ -76,7 +78,7 @@ class SpecialPageFactoryTest extends MediaWikiTestCase {
 	 * @covers SpecialPageFactory::getPage
 	 * @dataProvider specialPageProvider
 	 */
-	public function testGetPage( $spec ) {
+	public function testGetPage( $spec, $shouldReuseInstance ) {
 		$this->mergeMwGlobalArrayValue( 'wgSpecialPages', [ 'testdummy' => $spec ] );
 		SpecialPageFactory::resetList();
 
@@ -84,7 +86,7 @@ class SpecialPageFactoryTest extends MediaWikiTestCase {
 		$this->assertInstanceOf( 'SpecialPage', $page );
 
 		$page2 = SpecialPageFactory::getPage( 'testdummy' );
-		$this->assertEquals( true, $page2 === $page, "Should re-use instance:" );
+		$this->assertEquals( $shouldReuseInstance, $page2 === $page, "Should re-use instance:" );
 	}
 
 	/**