X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2Fsite%2FSiteListTest.php;h=534ed9c905be0e057f6c8674dd98e778880aa0d1;hb=12b4d386028f4aad69bad040d2ffcd8c0d7e0346;hp=8af2fc1b95a1eeeb8e01ae3a16e24c7cf9d59d3c;hpb=708528039d0c3aeb6353f25fee9ba8af69dafddf;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/site/SiteListTest.php b/tests/phpunit/includes/site/SiteListTest.php
index 8af2fc1b95..534ed9c905 100644
--- a/tests/phpunit/includes/site/SiteListTest.php
+++ b/tests/phpunit/includes/site/SiteListTest.php
@@ -80,16 +80,14 @@ class SiteListTest extends MediaWikiTestCase {
 	 * @covers SiteList::getSite
 	 */
 	public function testGetSiteByGlobalId( SiteList $sites ) {
-		if ( $sites->isEmpty() ) {
-			$this->assertTrue( true );
-		} else {
-			/**
-			 * @var Site $site
-			 */
-			foreach ( $sites as $site ) {
-				$this->assertEquals( $site, $sites->getSite( $site->getGlobalId() ) );
-			}
+		/**
+		 * @var Site $site
+		 */
+		foreach ( $sites as $site ) {
+			$this->assertEquals( $site, $sites->getSite( $site->getGlobalId() ) );
 		}
+
+		$this->assertTrue( true );
 	}
 
 	/**
@@ -110,6 +108,25 @@ class SiteListTest extends MediaWikiTestCase {
 		$this->assertTrue( true );
 	}
 
+	/**
+	 * @dataProvider siteListProvider
+	 * @param SiteList $sites
+	 * @covers SiteList::getSiteByNavigationId
+	 */
+	public function testGetSiteByNavigationId( $sites ) {
+		/**
+		 * @var Site $site
+		 */
+		foreach ( $sites as $site ) {
+			$ids = $site->getNavigationIds();
+			foreach ( $ids as $navId ) {
+				$this->assertEquals( $site, $sites->getSiteByNavigationId( $navId ) );
+			}
+		}
+
+		$this->assertTrue( true );
+	}
+
 	/**
 	 * @dataProvider siteListProvider
 	 * @param SiteList $sites
@@ -147,6 +164,25 @@ class SiteListTest extends MediaWikiTestCase {
 		$this->assertFalse( $sites->hasInternalId( -1 ) );
 	}
 
+	/**
+	 * @dataProvider siteListProvider
+	 * @param SiteList $sites
+	 * @covers SiteList::hasNavigationId
+	 */
+	public function testHasNavigationId( $sites ) {
+		/**
+		 * @var Site $site
+		 */
+		foreach ( $sites as $site ) {
+			$ids = $site->getNavigationIds();
+			foreach ( $ids as $navId ) {
+				$this->assertTrue( $sites->hasNavigationId( $navId ) );
+			}
+		}
+
+		$this->assertFalse( $sites->hasNavigationId( 'non-existing-navigation-id' ) );
+	}
+
 	/**
 	 * @dataProvider siteListProvider
 	 * @param SiteList $sites
@@ -192,6 +228,13 @@ class SiteListTest extends MediaWikiTestCase {
 		 */
 		foreach ( $list as $site ) {
 			$this->assertTrue( $copy->hasInternalId( $site->getInternalId() ) );
+
+			foreach ( $site->getNavigationIds() as $navId ) {
+				$this->assertTrue(
+					$copy->hasNavigationId( $navId ),
+					'unserialized data expects nav id ' . $navId . ' for site ' . $site->getGlobalId()
+				);
+			}
 		}
 	}
 }