X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2Fsession%2FBotPasswordSessionProviderTest.php;h=d4b15879c81d8ee2ea3307bb2a12812364bf5e76;hb=f826f2f5f6facdce2c92dcb9e70bb0cf20ff9db0;hp=5126a42138d9c01bf21b27afd4e2c5526e8b74ef;hpb=b2c6557fa74a9e0afcfbe9608e050bb99c32f2de;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/session/BotPasswordSessionProviderTest.php b/tests/phpunit/includes/session/BotPasswordSessionProviderTest.php
index 5126a42138..d4b15879c8 100644
--- a/tests/phpunit/includes/session/BotPasswordSessionProviderTest.php
+++ b/tests/phpunit/includes/session/BotPasswordSessionProviderTest.php
@@ -33,8 +33,8 @@ class BotPasswordSessionProviderTest extends MediaWikiTestCase {
 				'EnableBotPasswords' => true,
 				'BotPasswordsDatabase' => false,
 				'SessionProviders' => $wgSessionProviders + [
-					'MediaWiki\\Session\\BotPasswordSessionProvider' => [
-						'class' => 'MediaWiki\\Session\\BotPasswordSessionProvider',
+					BotPasswordSessionProvider::class => [
+						'class' => BotPasswordSessionProvider::class,
 						'args' => [ $params ],
 					]
 				],
@@ -46,7 +46,7 @@ class BotPasswordSessionProviderTest extends MediaWikiTestCase {
 			'store' => new TestBagOStuff,
 		] );
 
-		return $manager->getProvider( 'MediaWiki\\Session\\BotPasswordSessionProvider' );
+		return $manager->getProvider( BotPasswordSessionProvider::class );
 	}
 
 	protected function setUp() {
@@ -65,9 +65,7 @@ class BotPasswordSessionProviderTest extends MediaWikiTestCase {
 	public function addDBDataOnce() {
 		$passwordFactory = new \PasswordFactory();
 		$passwordFactory->init( \RequestContext::getMain()->getConfig() );
-		// A is unsalted MD5 (thus fast) ... we don't care about security here, this is test only
-		$passwordFactory->setDefaultType( 'A' );
-		$pwhash = $passwordFactory->newFromPlaintext( 'foobaz' );
+		$passwordHash = $passwordFactory->newFromPlaintext( 'foobaz' );
 
 		$userId = \CentralIdLookup::factory( 'local' )->centralIdFromName( 'UTSysop' );
 
@@ -82,7 +80,7 @@ class BotPasswordSessionProviderTest extends MediaWikiTestCase {
 			[
 				'bp_user' => $userId,
 				'bp_app_id' => 'BotPasswordSessionProvider',
-				'bp_password' => $pwhash->toString(),
+				'bp_password' => $passwordHash->toString(),
 				'bp_token' => 'token!',
 				'bp_restrictions' => '{"IPAddresses":["127.0.0.0/8"]}',
 				'bp_grants' => '["test"]',
@@ -154,7 +152,7 @@ class BotPasswordSessionProviderTest extends MediaWikiTestCase {
 	public function testBasics() {
 		$provider = $this->getProvider();
 
-		$this->assertTrue( $provider->persistsSessionID() );
+		$this->assertTrue( $provider->persistsSessionId() );
 		$this->assertFalse( $provider->canChangeUser() );
 
 		$this->assertNull( $provider->newSessionInfo() );
@@ -172,7 +170,7 @@ class BotPasswordSessionProviderTest extends MediaWikiTestCase {
 		}
 
 		$info = $provider->provideSessionInfo( $request );
-		$this->assertInstanceOf( 'MediaWiki\\Session\\SessionInfo', $info );
+		$this->assertInstanceOf( SessionInfo::class, $info );
 		$this->assertSame( 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa', $info->getId() );
 
 		$this->config->set( 'EnableBotPasswords', false );
@@ -191,7 +189,7 @@ class BotPasswordSessionProviderTest extends MediaWikiTestCase {
 		$bp = \BotPassword::newFromUser( $user, 'BotPasswordSessionProvider' );
 
 		$session = $provider->newSessionForRequest( $user, $bp, $request );
-		$this->assertInstanceOf( 'MediaWiki\\Session\\Session', $session );
+		$this->assertInstanceOf( Session::class, $session );
 
 		$this->assertEquals( $session->getId(), $request->getSession()->getId() );
 		$this->assertEquals( $user->getName(), $session->getUser()->getName() );