X-Git-Url: https://git.heureux-cyclage.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2Flibs%2Fobjectcache%2FHashBagOStuffTest.php;h=b2278c3437450ae6550d4c147e62910fe8ef4ef8;hb=f7e1770fb832aa77bf4e16ce8cc815f2b24dd10d;hp=c4db0cf8bf1b2504c8b51071a512f6c936d1e6f5;hpb=1617f6e55541d869d772dc84943b5a79feee4dc0;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php b/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php
index c4db0cf8bf..b2278c3437 100644
--- a/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php
+++ b/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php
@@ -1,10 +1,46 @@
 <?php
 
+use Wikimedia\TestingAccessWrapper;
+
 /**
  * @group BagOStuff
  */
 class HashBagOStuffTest extends PHPUnit_Framework_TestCase {
 
+	/**
+	 * @covers HashBagOStuff::__construct
+	 */
+	public function testConstruct() {
+		$this->assertInstanceOf(
+			HashBagOStuff::class,
+			new HashBagOStuff()
+		);
+	}
+
+	/**
+	 * @covers HashBagOStuff::__construct
+	 * @expectedException InvalidArgumentException
+	 */
+	public function testConstructBadZero() {
+		$cache = new HashBagOStuff( [ 'maxKeys' => 0 ] );
+	}
+
+	/**
+	 * @covers HashBagOStuff::__construct
+	 * @expectedException InvalidArgumentException
+	 */
+	public function testConstructBadNeg() {
+		$cache = new HashBagOStuff( [ 'maxKeys' => -1 ] );
+	}
+
+	/**
+	 * @covers HashBagOStuff::__construct
+	 * @expectedException InvalidArgumentException
+	 */
+	public function testConstructBadType() {
+		$cache = new HashBagOStuff( [ 'maxKeys' => 'x' ] );
+	}
+
 	/**
 	 * @covers HashBagOStuff::delete
 	 */
@@ -56,7 +92,6 @@ class HashBagOStuffTest extends PHPUnit_Framework_TestCase {
 	/**
 	 * Ensure maxKeys eviction prefers keeping new keys.
 	 *
-	 * @covers HashBagOStuff::__construct
 	 * @covers HashBagOStuff::set
 	 */
 	public function testEvictionAdd() {
@@ -76,7 +111,6 @@ class HashBagOStuffTest extends PHPUnit_Framework_TestCase {
 	 * Ensure maxKeys eviction prefers recently set keys
 	 * even if the keys pre-exist.
 	 *
-	 * @covers HashBagOStuff::__construct
 	 * @covers HashBagOStuff::set
 	 */
 	public function testEvictionSet() {
@@ -102,7 +136,6 @@ class HashBagOStuffTest extends PHPUnit_Framework_TestCase {
 	/**
 	 * Ensure maxKeys eviction prefers recently retrieved keys (LRU).
 	 *
-	 * @covers HashBagOStuff::__construct
 	 * @covers HashBagOStuff::doGet
 	 * @covers HashBagOStuff::hasKey
 	 */